mathrick
Member since Jul 24, 2014
- Profile: /members/12146-mathrick.htm
- Comments: 2
Recent Blog Comments By mathrick
-
Node.js Transform Streams vs. Through2 Streams
Posted on Jul 24, 2014 at 11:06 AM
@Ben, you're welcome! That's one of the reasons we have code reviews before anything gets into the tree here at work and I wouldn't have it any other way :) Also (you're free to ignore this!) : I prefer to write my nick all-lowercase. Just a tiny nitpick.... read more »
-
Node.js Transform Streams vs. Through2 Streams
Posted on Jul 24, 2014 at 4:11 AM
var parts = pattern.toString().slice( 1 ).split( "/" ); This is absolutely awful and brittle. Just try matching for "http://foo.bar/baz" and watch it explode. On top of that, toString() is not actually standardised, so different implementations might return other things than the... read more »